Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATMOSPHERE-364] cert-manager: Add support for Azure DNS #1601

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[ATMOSPHERE-364] cert-manager: Add support for Azure DNS #1601

merged 1 commit into from
Sep 6, 2024

Conversation

gtirloni
Copy link
Contributor

No description provided.

@gtirloni
Copy link
Contributor Author

@guilhermesteinmuller could you help test this?

@gtirloni gtirloni force-pushed the feat/cluster_issuer_azure branch 4 times, most recently from f3b3430 to b2eeba8 Compare July 16, 2024 20:25
guilhermesteinmuller
guilhermesteinmuller reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@guilhermesteinmuller guilhermesteinmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking now if we should support that.

I had issues with DNSSEC: NSEC Missing: validation failure while attempting to issue the cert and it looks like azure dns doesnt support that...

@gtirloni
Copy link
Contributor Author

@guilhermesteinmuller would mentioning that DNSSEC is not supported be enough or would you like to drop this work completely?

@gtirloni gtirloni force-pushed the feat/cluster_issuer_azure branch from b2eeba8 to ecdd3bd Compare July 25, 2024 17:09
@gtirloni gtirloni changed the title cert-manager: Add support for Azure DNS [ATMOSPHERE-364] cert-manager: Add support for Azure DNS Aug 5, 2024
@gtirloni gtirloni force-pushed the feat/cluster_issuer_azure branch from ecdd3bd to 3d91957 Compare August 5, 2024 14:06
@mnaser
Copy link
Member

mnaser commented Aug 12, 2024

recheck

@mnaser
Copy link
Member

mnaser commented Aug 14, 2024

/cherry-pick stable/2024.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2024.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member

mnaser commented Aug 14, 2024

/cherry-pick stable/2023.2

@mnaser
Copy link
Member

mnaser commented Aug 14, 2024

/cherry-pick stable/2023.1

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.2 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser
Copy link
Member

mnaser commented Aug 14, 2024

/cherry-pick stable/zed

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2023.1 in a new PR and assign it to you.

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot
Copy link
Collaborator

@mnaser: once the present PR merges, I will cherry-pick it on top of stable/zed in a new PR and assign it to you.

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mnaser mnaser added the gate label Aug 14, 2024
@mnaser
Copy link
Member

mnaser commented Sep 6, 2024

regate

@atmosphere-ci atmosphere-ci bot merged commit 43722d6 into vexxhost:main Sep 6, 2024
4 checks passed
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1862

In response to this:

/cherry-pick stable/2023.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot vexxhost-bot mentioned this pull request Sep 6, 2024
Merged
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1863

In response to this:

/cherry-pick stable/2023.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot vexxhost-bot mentioned this pull request Sep 6, 2024
Merged
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1864

In response to this:

/cherry-pick stable/zed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot vexxhost-bot mentioned this pull request Sep 6, 2024
Merged
@vexxhost-bot
Copy link
Collaborator

@mnaser: new pull request created: #1865

In response to this:

/cherry-pick stable/2024.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vexxhost-bot vexxhost-bot mentioned this pull request Sep 6, 2024
Merged
atmosphere-ci bot pushed a commit that referenced this pull request Sep 9, 2024
@vexxhost-bot
[stable/2023.2] [ATMOSPHERE-364] cert-manager: Add support for Azure …
7848835 
…DNS (#1862)

This is an automated cherry-pick of #1601
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Sep 9, 2024
@vexxhost-bot
[stable/2023.1] [ATMOSPHERE-364] cert-manager: Add support for Azure …
426043d 
…DNS (#1863)

This is an automated cherry-pick of #1601
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Sep 9, 2024
@vexxhost-bot
[stable/zed] [ATMOSPHERE-364] cert-manager: Add support for Azure DNS (…
1ba9adb 
…#1864)

This is an automated cherry-pick of #1601
/assign mnaser
atmosphere-ci bot pushed a commit that referenced this pull request Sep 9, 2024
@vexxhost-bot
[stable/2024.1] [ATMOSPHERE-364] cert-manager: Add support for Azure …
ba6c62a 
…DNS (#1865)

This is an automated cherry-pick of #1601
/assign mnaser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser Awaiting requested review from mnaser

@guilhermesteinmuller guilhermesteinmuller Awaiting requested review from guilhermesteinmuller

Assignees
No one assigned
Labels
gate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gtirloni @mnaser @vexxhost-bot @guilhermesteinmuller